Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6793#discussion_r32374653
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ArithmeticExpressionSuite.scala
 ---
    @@ -69,6 +69,7 @@ class ArithmeticExpressionSuite extends SparkFunSuite 
with ExpressionEvalHelper
     
         checkEvaluation(-c1, -1.1, row)
         checkEvaluation(c1 + c2, 3.1, row)
    +    checkDoubleEvaluation(Rand(30), (0.7363714192755834 +- 0.001), row)
    --- End diff --
    
    can we create a new test case, instead of adding it to the existing one?
    
    I've been meaning to take the existing one apart for a while.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to