juliuszsompolski commented on code in PR #55858:
URL: https://github.com/apache/spark/pull/55858#discussion_r3530027521
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/dynamicpruning/RowLevelOperationRuntimeGroupFiltering.scala:
##########
@@ -64,6 +64,7 @@ class
RowLevelOperationRuntimeGroupFiltering(optimizeSubqueries: Rule[LogicalPla
scan: SupportsRuntimeV2Filtering): Boolean = {
conf.runtimeRowLevelOperationGroupFilterEnabled &&
cond != TrueLiteral &&
+ cond.deterministic &&
Review Comment:
For ReplaceData, not injecting the group filter will lead to always
rewriting the whole table on MERGE.
I would hold off on it until MERGE materialization is in place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
