yadavay-amzn commented on PR #56417: URL: https://github.com/apache/spark/pull/56417#issuecomment-4931438368
@mihailotim-db Thanks for taking a look! On the approach, I agree the end state is to resolve these through the grouping-analytics handlers rather than guard them, and your e2e fix is suitable for that. As @cloud-fan summarized, the scope here is narrower; we convert the current hard crash into an explicit `ExplicitlyUnsupportedResolverFeature`, so tentative/dual-run mode falls back to the fixed-point analyzer and returns correct results. The three guards are isolated and easy to delete once your fix adds the real resolution. I'm okay with either sequencing: merge this now as the interim crash-fix and let your PR remove the guards when it merges, or hold it if your e2e fix is close and would supersede it. If it's easier for you, I can also close this in favor of your fix, or rebase so your PR drops the guards cleanly. Whatever minimizes churn on your side. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
