dongjoon-hyun opened a new pull request, #57281:
URL: https://github.com/apache/spark/pull/57281

   ### What changes were proposed in this pull request?
   
   Log only non-sensitive fields (`masterUrl`, `namespace`, `apiVersion`, 
`requestTimeout`,
   `connectionTimeout`, `trustCerts`) in the DEBUG log line of
   `SparkKubernetesClientFactory.createKubernetesClient`, instead of 
serializing the entire fabric8
   `Config` object with a plain `ObjectMapper`.
   
   ### Why are the changes needed?
   
   `Config` holds the API server credentials, and a plain `ObjectMapper` 
applies no masking, so the
   previous line logged `oauthToken`, `clientKeyData`, `caCertData`, 
`clientCertData`, the basic-auth
   password, and the truststore password in cleartext. (`oauthToken` is 
annotated `@JsonIgnore`, but
   `@JsonIgnoreProperties(allowGetters = true)` on the class re-enables it via 
its getter.)
   `createKubernetesClient` runs on both the submission client and the driver, 
and driver logs are
   commonly collected and archived.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No. DEBUG log content only.
   
   ### How was this patch tested?
   
   Pass the CIs.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Fable 5


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to