szehon-ho commented on code in PR #57245:
URL: https://github.com/apache/spark/pull/57245#discussion_r3591790870
##########
sql/pipelines/src/main/scala/org/apache/spark/sql/pipelines/graph/GraphValidations.scala:
##########
@@ -253,7 +253,12 @@ trait GraphValidations extends Logging {
}
protected def validateUserSpecifiedSchemas(): Unit = {
- flows.flatMap(f => table.get(f.identifier)).foreach { t: TableElement =>
+ // Look up tables by their destination identifier, not by the flow's own
identifier. The two
+ // coincide only for an implicit/default flow (whose identifier equals its
destination
+ // table's); for a named flow (e.g. `CREATE FLOW <name> AS AUTO CDC INTO
<target>`) they
+ // differ, and keying on the flow identifier would silently skip
validation. `flowsTo` is
Review Comment:
nit: can we remove this comment 'flowsTo' is grouped by destination...
mirroring 'validateFlowStreamingness'
(seems too low level)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
