mihailoale-db commented on PR #57122: URL: https://github.com/apache/spark/pull/57122#issuecomment-4992295055
Hey @gaogaotiantian, thanks for sharing your concerns. 1. I don't think that it's necessary to include these files in `MANIFEST.in`. I can revert it if that makes sense. 2. I would say that having a script per file is convenient from the perspective of parsing both the input and results. IMO it's easily manageable in the agentic world. Although we could choose a different option we went with "script per file" approach, it's a design decision, as simple as that. 3. I'm not sure that I understand this part. Where would you place it? 4. There are couple of new things introduced with this framework. As you can see the results are inlined right after the script so we don't have to jump around inputs, end results and analyzer plan results. Also we introduced the optimized results as an improvement. 5. Yes the initial plan was to introduce the framework and initial tests in this PR and to add more tests in subsequent PRs. We model the tests based on SQL queries from the `sql/core/src/test/resources/sql-tests/inputs` and I would expect people who contribute to SQL golden files to add DF golden files as well. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
