jerrypeng commented on PR #57286: URL: https://github.com/apache/spark/pull/57286#issuecomment-4997306813
> SparkSubmitSuite.scala (~line 1520, not in this diff): the SPARK-45762 test generates a user-jar Java class with @Override public ShuffleBlockResolver shuffleBlockResolver() that implements org.apache.spark.shuffle.ShuffleManager. Removing shuffleBlockResolver from the base trait (it moved to BlockingShuffleManager) makes that @Override target a nonexistent method — TestUtils.createCompiledClass (javac at runtime) fails and the test breaks. Since the extension point is being kept, update the generated class to implement BlockingShuffleManager, not remove the test. Nice catch — this class is compiled by javac at test runtime via TestUtils.createCompiledClass, so it slipped past core/Test/compile. Will update that test as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
