zhengruifeng commented on PR #56584: URL: https://github.com/apache/spark/pull/56584#issuecomment-5021938695
I think we will evntually override `def estimatedSize` for all builtin ML algorithms. While a new `def estimate(obj: AnyRef, skipTransient: Boolean)` as a default in ML `Model` still make sense for 3-rd implementations, so I am fine with it. Then I think we need more eyes from the core modules. @cloud-fan @Ngone51 @pan3793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
