cloud-fan commented on code in PR #57183: URL: https://github.com/apache/spark/pull/57183#discussion_r3615542412
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala: ########## @@ -60,6 +60,11 @@ import org.apache.spark.util.ArrayImplicits._ // scalastyle:off line.size.limit @ExpressionDescription( usage = "_FUNC_(sep[, str | array(str)]+) - Returns the concatenation of the strings separated by `sep`, skipping null values.", + arguments = """ + Arguments: + * sep - The separator placed between the concatenated values. Review Comment: `concat_ws` still documents only `sep`, although the usage and `inputTypes` also expose the variadic string-or-array-of-strings argument. Please add that argument and its accepted types so this function has the per-argument coverage promised by the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
