gaogaotiantian commented on code in PR #57233:
URL: https://github.com/apache/spark/pull/57233#discussion_r3617850106
##########
pyproject.toml:
##########
@@ -198,3 +212,49 @@ dev = [
{include-group = "pandas_on_spark_extra"},
{include-group = "pipelines"},
]
+
+_ci_connect = [
+ {include-group = "connect"},
+ "grpcio==1.76.0",
+ "grpcio-status==1.76.0",
+ "googleapis-common-protos==1.71.0",
+ "zstandard==0.25.0",
+ "protobuf==6.33.5",
+]
+
+ci_connect_standard = [
+ {include-group = "_ci_connect"},
+ "graphviz==0.20.3",
+]
+
+ci_connect_minimum = [
Review Comment:
You are right. This specific config was not used at this point but we should
solve it. I believe we need to change the version requirements for `graphviz`
to `>=0.20` for `connect` because that's what we have in our documentation -
https://spark.apache.org/docs/latest/api/python/getting_started/install.html .
I was trying to change that when I move dependency list from `requirements.txt`
but was informed that the PR should be only about refactoring - anything else
should be done in a separate PR.
I will change the `graphviz` requirement first then merge this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
