dongjoon-hyun commented on PR #57358: URL: https://github.com/apache/spark/pull/57358#issuecomment-5042383875
I would agree with @uros-b 's comment if this is a normal branch. However, I prefer @holdenk 's approach for now. > It will fail again on any future version-string-length change or Parquet bump on 3.5. Technically, @uros-b 's argument is invalid because 1. We are not going to bump to 3.5.100-SNAPSHOT in the remaining `branch-3.5` lifetime. 2. Currently we are using Apache Parquet 1.13.1 and Apache Spark community is very reluctant to change Apache Parquet version from 1.13.1 to 1.13.2 in `branch-3.5`. https://github.com/apache/spark/blob/71d3aca6b37ae5446538e5304bb420172a18dd11/pom.xml#L143 Moreover, Apache Parquet 1.13.2 doesn't exist and I don't think Apache Parquet community will do a new security releases for 1.13.1. For the following, we didn't backport SPARK-53422 to `branch-4.0` also. So, @uros-b 's suggestion implies to change `branch-4.0` for this `branch-3.5`'s special case. This is also not desirable. > A better fix ([SPARK-53422](https://issues.apache.org/jira/browse/SPARK-53422)) is already merged on master. S hould we consider cherry picking it? I'd like to recommend to merge this surgical one to `branch-3.5` as a last part of @holdenk 's Apache Spark 3.5.9 release manager role because this has been broken due to the release commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
