juliuszsompolski commented on code in PR #54653: URL: https://github.com/apache/spark/pull/54653#discussion_r3636519905
########## common/utils/src/main/scala/org/apache/spark/internal/config/ConfigBindingPolicy.scala: ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.internal.config + +/** + * Defines how a configuration value is bound when used within SQL views, UDFs, or procedures. + * + * This enum controls whether a config value propagates from the active session or uses the value + * saved during view/UDF/procedure creation. If the policy is PERSISTED, but there is no saved + * value, a Spark default value is used. + * + * This is particularly important for configs that affect query behavior and where views/UDFs/ + * procedures should change their behavior based on the caller's session settings. If the policy + * is PERSISTED, session-level config changes will not apply to views/UDFs/procedures but only + * to outer queries. In order for session-level changes to propagate correctly, this value must + * be explicitly set to SESSION. + */ +object ConfigBindingPolicy extends Enumeration { + type ConfigBindingPolicy = Value + + /** + * The config value propagates from the active session to views/UDFs/procedures. + * This is important for queries that should have uniform behavior across the entire query. + */ + val SESSION: Value = Value("SESSION") + + /** + * The config uses the value saved on view/UDF/procedure creation if it exists, + * or Spark default value for that config if it doesn't. + */ + val PERSISTED: Value = Value("PERSISTED") Review Comment: Got it. I think with no examples of in the code, and in the age of LLMs writing most of the code, I feel that we're running the risk of the annotations getting cargo-culted to NOT_APPLICABLE or SESSION just to get the CI happy. I got here via reviewing https://github.com/apache/spark/pull/57323#discussion_r3633917156 and asking myself what it should be for a LEGACY_ flag affecting a behavior change of an operator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
