dongjoon-hyun opened a new pull request, #443:
URL: https://github.com/apache/spark-connect-swift/pull/443

   ### What changes were proposed in this pull request?
   
   This PR aims to fix `SparkConnectClient.defineFlow` to send the given 
`Relation` to the server via the `relation_flow_details` field of 
`PipelineCommand.DefineFlow`.
   
   Since the `4.1.0-preview3` generated code update ([SPARK-54043]), the 
`relation` assignment has been commented out because the upstream proto moved 
the `relation` field into the `details` oneof (`WriteRelationFlowDetails`). As 
a result, the caller-provided `Relation` was silently dropped and flows were 
defined without a query.
   
   ### Why are the changes needed?
   
   To fix a bug where `defineFlow` defines a flow without its defining query.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, `defineFlow` is an internal API.
   
   ### How was this patch tested?
   
   Pass the CIs with a newly added test case.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Fable 5


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to