eason-yuchen-liu opened a new pull request, #57580:
URL: https://github.com/apache/spark/pull/57580

   ### What changes were proposed in this pull request?
   
   Restore the single-argument `nextWithTimeout(Long timeoutMs)` method on the 
`@Evolving` `SupportsRealTimeRead` interface, which SPARK-55699 replaced with 
`nextWithTimeout(Long startTimeMs, Long timeoutMs)`. Both overloads are now 
`default` methods:
   
   - `nextWithTimeout(Long)` throws `UnsupportedOperationException` by default.
   - `nextWithTimeout(Long, Long)` delegates to `nextWithTimeout(Long)` by 
default, ignoring `startTimeMs`.
   
   A source overrides whichever one it needs. The engine always invokes the 
two-argument overload, so a source that overrides only the single-argument 
variant (as external Spark 4.1-era sources do) is driven through the 
delegation. Internal implementors (`LowLatencyMemoryStream`, Kafka) already 
override the two-argument variant and are unchanged.
   
   ### Why are the changes needed?
   
   SPARK-55699 changed the sole abstract method on the public interface rather 
than adding an overload, which is a source- and binary-incompatible break. An 
external source (a custom MQTT Real-Time Mode connector) that implemented 
`nextWithTimeout(Long)` no longer compiles or links after upgrading from Spark 
4.1 to 4.2. The `startTimeMs` parameter is only needed for the 
manual-clock/test path, so it should not be forced on external implementors.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. It restores the Spark 4.1 `nextWithTimeout(Long)` method on the 
`SupportsRealTimeRead` interface, so external sources written against Spark 4.1 
compile and link again.
   
   ### How was this patch tested?
   
   Verified locally that a Real-Time Mode source implementing only the 
single-argument `nextWithTimeout(Long)` is driven correctly end-to-end by a 
streaming query through the two-argument default delegation, and that existing 
RTM suites (`StreamRealTimeModeSuite`, 
`StreamRealTimeModeWithManualClockSuite`, `StreamRealTimeModeE2ESuite`) 
continue to pass.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 4.8)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to