cloud-fan commented on code in PR #57650:
URL: https://github.com/apache/spark/pull/57650#discussion_r3685104387
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/V1WriteCommandSuite.scala:
##########
@@ -438,4 +438,61 @@ class V1WriteCommandSuite extends SharedSparkSession with
V1WriteCommandSuiteBas
}
}
}
+
+ test("SPARK-58444: planned write should not enable concurrent writer when
ordering " +
+ "already matched") {
+ // The concurrent output writer keeps one open writer per dynamic
partition and falls back
+ // to the sort-based sequential writer once the number of open writers
exceeds
Review Comment:
The fallback condition is inclusive (`size >= maxWriters`), so the current
wording documents the wrong boundary. Please make the same correction in the
control-case comment below.
```suggestion
// to the sort-based sequential writer once the number of open writers
reaches
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
