peter-toth commented on code in PR #57437: URL: https://github.com/apache/spark/pull/57437#discussion_r3695121025
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BroadcastValueProjection.scala: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.expressions + +import org.apache.spark.sql.catalyst.plans.QueryPlan +import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan + +/** + * Describes a value projection from the rows of an existing standard hash broadcast. + * + * The source hash keys are the complete, ordered keys of the broadcast join. The value expression + * is evaluated against the rows stored in the resulting hashed relation. + */ +case class BroadcastValueProjection( + sourcePlan: LogicalPlan, + sourceHashKeys: Seq[Expression], + valueExpression: Expression) { + + lazy val canonicalized: BroadcastValueProjection = { Review Comment: **Finding 6.** This `canonicalized` is unreachable — nothing in the tree calls it. Both holders of a `BroadcastValueProjection` deliberately drop it when canonicalizing: - `DynamicPruningSubquery.canonicalized` → `copy(...)(None)` (`sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/DynamicPruning.scala:117`) - `SubqueryAdaptiveBroadcastExec.doCanonicalize` → `copy(...)(None)` (`sql/core/src/main/scala/org/apache/spark/sql/execution/SubqueryAdaptiveBroadcastExec.scala:53`) and both are pinned by tests asserting `broadcastValueProjection.isEmpty` after `canonicalized`. Grepping `BroadcastValueProjection` across the tree turns up no `.canonicalized` call, so this member — and the `QueryPlan` import on line 20 that only it needs — is dead. Worth deleting rather than leaving: as written it suggests the projection participates in canonicalization, which is the opposite of the design the tests lock in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
