uros-b commented on code in PR #57681:
URL: https://github.com/apache/spark/pull/57681#discussion_r3700479289
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala:
##########
@@ -1029,6 +1030,62 @@ abstract class OrcQuerySuite extends OrcQueryTest with
SharedSparkSession {
}
}
+ test("SPARK-57823: ORC predicate pushdown returns correct results for nanos
timestamps") {
Review Comment:
The new end-to-end correctness test (checkAnswer + stripe-skip assertion)
for TimestampLTZNanosType runs at whatever JVM timezone the test process uses.
Because Spark CI runs in UTC, the LTZ timezone bug above goes undetected. The
test should wrap the LTZ case in
DateTimeTestUtils.withDefaultTimeZone(non-UTC_zone) (e.g. DateTimeTestUtils.LA
or a UTC-ahead zone like Asia/Kolkata) to exercise the filter-literal epoch
conversion under a real zone offset and catch data-loss regressions. (Existing
SPARK-57455 test in the same suite demonstrates the correct pattern.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
