uros-b commented on code in PR #57629:
URL: https://github.com/apache/spark/pull/57629#discussion_r3700559951
##########
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala:
##########
@@ -3547,6 +3548,22 @@ class DataFrameAggregateSuite extends SharedSparkSession
}
}
+ test("SPARK-58420: reuse map sort for grouping and distinct aggregates") {
Review Comment:
Now that the rule builds two projection layers, two alias namespaces and a
reuse path, a catalyst-level PlanTest suite would pin the structural invariants
more precisely than the MapSort count in DataFrameAggregateSuite; one alias
when a grouping key and a distinct argument coincide, a single Project when
every distinct argument is already an attribute, and the killswitch path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
