cloud-fan commented on code in PR #57721:
URL: https://github.com/apache/spark/pull/57721#discussion_r3705205997
##########
sql/core/src/test/scala/org/apache/spark/sql/PushDownJoinThroughUnionSuite.scala:
##########
@@ -62,9 +70,11 @@ class PushDownJoinThroughUnionSuite
withTempView("fact1", "fact2", "fact3", "dim") {
withSQLConf(
SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "10485760") {
- val fact1 = Seq((1, 10), (2, 20)).toDF("id", "amount")
- val fact2 = Seq((3, 30), (4, 40)).toDF("id", "amount")
- val fact3 = Seq((1, 50), (5, 60)).toDF("id", "amount")
+ // Twelve rows per branch keeps every branch strictly larger than the
dimension table in
Review Comment:
The plural subject needs `keep`.
```suggestion
// Twelve rows per branch keep every branch strictly larger than the
dimension table in
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
