cloud-fan commented on code in PR #57261:
URL: https://github.com/apache/spark/pull/57261#discussion_r3728228826


##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -3633,8 +3633,20 @@
   },
   "INVALID_BUCKET_COUNT" : {
     "message" : [
-      "Number of buckets should be greater than 0 but less than or equal to 
bucketing.maxBuckets (`<bucketingMaxBuckets>`). Got `<numBuckets>`."
+      "Invalid number of buckets."
     ],
+    "subClass" : {
+      "NON_INTEGER_LITERAL" : {

Review Comment:
   Please keep this failure under a condition whose SQLSTATE is 22023 (`invalid 
parameter value`), such as `INVALID_PARAMETER_VALUE.INTEGER`, rather than under 
`INVALID_BUCKET_COUNT`. This branch rejects a non-integer literal before range 
validation, so inheriting 22003 reports `numeric value out of range` for a 
type/parameter error.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to