peter-toth commented on code in PR #57585:
URL: https://github.com/apache/spark/pull/57585#discussion_r3741461076
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/RelationCatalog.java:
##########
@@ -105,10 +106,13 @@
* questions in two round trips each. {@code RelationCatalog} adds dedicated
methods so a
* catalog can answer both in one round trip:
* <ul>
- * <li>{@link #loadRelation(Identifier)} -- the resolver's per-identifier
read path. Returns a
- * {@link Table} for a table or a {@link View} for a view; callers
discriminate via
- * {@code instanceof}. Saves the {@code loadTable} -> {@code loadView}
fallback on a cold
- * cache.</li>
+ * <li>{@link #loadRelation(Identifier)} -- returns a {@link Table} for a
table or a
+ * {@link View} for a view; callers discriminate via {@code instanceof}.
Saves the
+ * {@code loadTable} -> {@code loadView} fallback on a cold cache. Used
for lookups that
+ * carry no read options (DDL and miscellaneous commands), and as the
base that the
+ * {@code loadTable} / {@code loadView} defaults derive from.</li>
Review Comment:
**Finding 10.** My round-1 wording predated the `loadTable` override you
added, so it is now a hair off: `loadTable(Identifier, TableContext,
CaseInsensitiveStringMap)` derives from the *options-aware* overload (`:212`,
`:225`), not from this one. Only `loadTable(Identifier)` (`:203`) and
`loadView` (`:241`) still derive from the 1-arg. Naming the overload keeps the
two javadocs from disagreeing:
```suggestion
* {@code loadTable(Identifier)} / {@code loadView} defaults derive
from.</li>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
