ilicmarkodb opened a new pull request, #57900:
URL: https://github.com/apache/spark/pull/57900
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
This PR makes collation-aware ICU case conversion use the requested collation
locale instead of the collator's resolved actual locale.
In particular, `CollationFactory.Collation` now stores the locale to use for
case conversion. ICU upper, lower, and title case conversion then read that
locale directly instead of calling `getLocale(ULocale.ACTUAL_LOCALE)` on the
collator.
### Why are the changes needed?
Some ICU collators resolve their actual locale to root even when the
requested
collation locale has language-specific case conversion rules. Dutch
titlecase is
one such case: `initcap('erik ijzermans' COLLATE NL)` should capitalize the
Dutch `ij` digraph as `Erik IJzermans`, not `Erik Ijzermans`.
### Does this PR introduce _any_ user-facing change?
Yes. This is a correctness fix for collation-aware case conversion. For
example,
`initcap('erik ijzermans' COLLATE NL)` now returns `Erik IJzermans`.
### How was this patch tested?
Added regression coverage in:
```
common/unsafe/src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java
sql/core/src/test/scala/org/apache/spark/sql/collation/CollationSQLFunctionsSuite.scala
```
Attempted to run:
```
build/sbt "unsafe/testOnly
org.apache.spark.unsafe.types.CollationSupportSuite" \
"sql/testOnly org.apache.spark.sql.collation.CollationSQLFunctionsSuite --
-z \"initcap uses locale-specific collation rules\""
```
The test run was blocked in this environment before test execution because
Maven
Central DNS resolution failed while loading the SBT project:
```
repo.maven.apache.org: Name or service not known
```
Local checks passed:
```
git diff --check
```
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
