zhengruifeng commented on code in PR #57818: URL: https://github.com/apache/spark/pull/57818#discussion_r3754920300
########## AGENTS.md: ########## @@ -202,6 +202,8 @@ It lists `master` and the latest major's release branches the commit reached (e. PR title format is `[SPARK-xxxx][COMPONENT] Title`. Draft, WIP, MINOR, and TRIVIAL PRs may omit the JIRA ID. The component tag is derived from the JIRA component name: take the last word and uppercase it (e.g. `Project Infra` → `[INFRA]`, `Spark Core` → `[CORE]`, `Structured Streaming` → `[STREAMING]`, `SQL` → `[SQL]`). +If a PR follows up on one or more earlier PRs whose changes have not been released, reuse their existing JIRA ticket(s) and add `[FOLLOWUP]` to the PR title. If any earlier change has been released, create a new JIRA ticket and do not use `[FOLLOWUP]`. Review Comment: Defined in the latest revision: `[FOLLOWUP]` means directly modifying or correcting specific unreleased earlier work, such as post-merge feedback or a regression. Planned parts of the original JIRA scope are continuations. ########## AGENTS.md: ########## @@ -202,6 +202,8 @@ It lists `master` and the latest major's release branches the commit reached (e. PR title format is `[SPARK-xxxx][COMPONENT] Title`. Draft, WIP, MINOR, and TRIVIAL PRs may omit the JIRA ID. The component tag is derived from the JIRA component name: take the last word and uppercase it (e.g. `Project Infra` → `[INFRA]`, `Spark Core` → `[CORE]`, `Structured Streaming` → `[STREAMING]`, `SQL` → `[SQL]`). +Use `[FOLLOWUP]` only when a PR directly modifies or corrects unreleased work from one or more specific earlier PRs, such as addressing post-merge review feedback or fixing a regression introduced by those changes. A separately planned PR that implements another part of a JIRA's original scope is a continuation: reuse the JIRA and use the normal title format without `[FOLLOWUP]`. If the work falls outside the original scope, or if any earlier change has been released, create a new JIRA ticket and do not use `[FOLLOWUP]`. Otherwise, reuse the earlier PRs' JIRA ticket(s) and insert `[FOLLOWUP]` after the component tag, for example `[SPARK-xxxx][COMPONENT][FOLLOWUP] Title`. Review Comment: Yes. #56684 and #56686 reuse SPARK-57625 as 1/2 and 2/2; #54978, #54997, and #55002 reuse SPARK-56179 as parts 1–3. None use `[FOLLOWUP]`. These are the planned continuation case I meant, as opposed to a corrective PR caused by a specific merged PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
