zhengruifeng commented on PR #57122: URL: https://github.com/apache/spark/pull/57122#issuecomment-5265694036
We already have one golden file framework in scala side, the PlanGenerationTestSuite → ProtoToParsedPlanTestSuite pipeline. It already covers `DataFrame API → connect proto → analyzed plan`. https://github.com/apache/spark/blob/274049387f96976c1bda1bedca3e6f96894c7e8e/sql/connect/client/jvm/src/test/scala/org/apache/spark/sql/PlanGenerationTestSuite.scala#L413-L427 isn't this new one kind of redundant? or it is testing some python-specific features? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
