pavan51 commented on PR #57346: URL: https://github.com/apache/spark/pull/57346#issuecomment-5268531588
Thanks for the detailed review @peter-toth and @cloud-fan! All findings from the latest rounds have been addressed: * **Findings 14 & 15:** The config version is corrected to `4.4.0` and the dead shrinking-frame path is completely removed. * **Finding 16:** The unrelated scalafmt reformatting has been reverted. * **Finding 17:** `numMonotonicDequeFrames` bumping has been moved into the `prepare()` method so it aligns with segment tree metrics. * **Findings 11 & 19 (Benchmarks):** Section B now properly respects the smoke mode arguments, and Section H avoids dragging `blockSize=256` into narrow windows. * **Finding 20 & PR Body Nit:** I've updated the PR description to remove the author-local file path and deleted the obsolete claim about shrinking frames. * **Allowlist Correctness (cloud-fan):** I've updated `WindowSegmentTreeAllowlistSuite` to assert strict baseline data equivalence for all non-allowlisted aggregate fallback paths, rather than just checking that the metrics remain 0. Let me know if everything looks good! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
