qlong commented on code in PR #57956:
URL: https://github.com/apache/spark/pull/57956#discussion_r3768894997
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PullOutVariantExtractions.scala:
##########
@@ -177,11 +177,20 @@ object PullOutVariantExtractions extends
Rule[LogicalPlan] {
case _ => false
}
+ private def isJoinHoistable(e: Expression): Boolean = {
Review Comment:
+1 on using throwable, it is cleaner. Minor suggestion, please feel free to
ignore. I am a bit worried there is no clear signal for hoist behavior change
when someone classifies Cast and VariantGet as throwable in the future. Should
we add a unit test to assert those two are throwable and add some comment
there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
