Spenserrrr commented on code in PR #57702:
URL: https://github.com/apache/spark/pull/57702#discussion_r3792901204
##########
python/pyspark/sql/tests/connect/test_connect_basic.py:
##########
@@ -842,6 +842,15 @@ def test_select_expr(self):
.toPandas(),
)
+ self.assert_eq(
+ self.connect.read.table(self.tbl_name)
+ .selectExpr(("id * 2", "cast(name as long) as name"))
Review Comment:
Thanks @gaogaotiantian, and that makes sense to me. I agree that the
annotation should match the runtime behavior, and it would be confusing to
accept a tuple of columns on some of these APIs but not others.
@HyukjinKwon, does this address your concern, or do you still see a downside
to supporting it? Happy to go with whatever you two prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
