pratham76 commented on PR #58023: URL: https://github.com/apache/spark/pull/58023#issuecomment-5311013926
> One optional nice-to-have, non-blocking: the root cause is a LiteralValue.toString rendering contract, so a small catalyst-level unit assertion (LiteralValue(null, StringType).toString == "NULL") would pin it more directly and faster than the H2 end-to-end test. The JDBCV2Suite test is good as the user-visible regression check; the unit test would just nail the contract. Thanks for the comments @viirya, have added a catalyst level unit test in `LiteralValueSuite` that directly tests the `LiteralValue.toString` contract: * Verifies null literals of all types (String, Integer, Boolean, Binary) render as "NULL" * Verifies non-null literals render correctly (quoted strings, unquoted numbers, hex binary) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
