GitHub user mallman opened a pull request:
https://github.com/apache/spark/pull/6832
Scala version switching build enhancements
These commits address a few minor issues in the Scala cross-version support
in the build:
1. Correct two missing `${scala.binary.version}` pom file substitutions.
2. Don't update `scala.binary.version` in parent POM. This property is
set through profiles.
3. Update the source of the generated scaladocs in
`docs/_plugins/copy_api_dirs.rb`.
4. Factor common code out of `dev/change-version-to-*.sh` and add some
validation. We also test `sed` to see if it's GNU sed and try `gsed` as an
alternative if not. This prevents the script from running with a non-GNU sed.
This is my first contribution to Spark. After reading the contributor
guidelines I wasn't sure if this qualified for a Jira ticket, or if I should
split these commits into separate contributions. I'm happy to amend my pull
request or file a Jira ticket as requested.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/VideoAmp/spark-1 scala-versions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/6832.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6832
----
commit 475088e7423b59dd7a9ef4b0ab426ebcc3e555ba
Author: Michael Allman <mich...@videoamp.com>
Date: 2015-06-14T19:17:56Z
Replace jackson-module-scala_2.10 with
jackson-module-scala_${scala.binary.version}
commit e5a675e3411bdfa3e6e387f6688f330fb8e5067b
Author: Michael Allman <mich...@videoamp.com>
Date: 2015-06-14T19:20:36Z
Don't update scala.binary.version in parent POM. This property is set
through profiles
commit a896dfdff26e56f8c6f0a4769b1d576e3494a524
Author: Michael Allman <mich...@videoamp.com>
Date: 2015-06-14T19:34:57Z
Update source of scaladocs when changing Scala version
commit 2b926205ff863c1132f3e1d923ff4715ee566bbc
Author: Michael Allman <mich...@videoamp.com>
Date: 2015-06-14T19:36:10Z
Factor change-scala-version.sh out of change-version-to-*.sh, adding
command line argument validation and testing for GNU sed
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
