peter-toth commented on code in PR #58002:
URL: https://github.com/apache/spark/pull/58002#discussion_r3821987476
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/functions/BoundFunction.java:
##########
@@ -90,6 +90,14 @@ default boolean isDeterministic() {
* functions in other catalogs. For example, many catalogs may define a
"bucket" function with a
* different implementation. Adding context, like
"com.mycompany.bucket(string)", is recommended
* to avoid unintentional collisions.
+ * <p>
+ * Two functions that partition data differently must not return the same
name; Spark may
+ * otherwise treat unrelated data as co-partitioned. An override should
return a stable name
Review Comment:
Thanks for the suggestion. Fixed in
https://github.com/apache/spark/pull/58002/commits/62995053577605c586804b04169f6c61d3283fcc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
