Yicong-Huang commented on code in PR #58199:
URL: https://github.com/apache/spark/pull/58199#discussion_r3828657721
##########
python/pyspark/tests/upstream/pyarrow/test_pyarrow_array_from_pandas_non_default.py:
##########
@@ -272,6 +273,13 @@ def test_from_pandas_type_scalar_unsafe(self):
overrides[("large_binary[pyarrow]:standard", col)] = (
"[b'hello', b'world']@large_binary"
)
+ # inf -> int is undefined behavior in C++; x86 (the golden's platform)
yields the
+ # "integer indefinite" INT_MIN, while ARM's FCVT saturates to INT_MAX.
Linux
+ # aarch64 and macOS arm64 agree on these two cells (safe=True rejects
inf -> int on
+ # every platform, so only this unsafe method needs the override).
+ if platform.machine() in ("aarch64", "arm64"):
+ overrides[("float64:infinity", "int8")] = "[-1, 1]@int8"
+ overrides[("float64:infinity", "int64")] = "[9223372036854775807,
1]@int64"
Review Comment:
I thought we want to skip the different OS/arch tests? I am also fine if we
override to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
