srielau commented on PR #58130: URL: https://github.com/apache/spark/pull/58130#issuecomment-5381672993
Thanks for the re-review. Both lows are addressed in ff948fd. **1. PR description.** This one was already fixed -- the description was updated at the same minute the review was posted, so you were reading the previous snapshot. It currently reads: > - Use `ExpectsInputTypes` for `StringSplitSQL`. > - Give `JsonTuple` a CHAR/VARCHAR-only coercion arm so its existing INT and untyped NULL validation remains unchanged. **2. JsonTuple tests and the arm comment.** The rule tests moved out of `cast NullType for expressions that implement ExpectsInputTypes` into their own `coerce JsonTuple children without the NullType rewrite`, which is what they actually pin: NULL unchanged, INT unchanged, CHAR promoted under the flag. The `Upper` CHAR case stays behind in the original test, since that one really is an `ExpectsInputTypes` expression. The arm itself now carries the warning: ```scala // JsonTuple validates its own input types and rejects non-string children with // NON_STRING_TYPE, so it only takes the CHAR/VARCHAR promotion here. Do not fold this into // the ExpectsInputTypes arm below: that would also apply the NullType rewrite and turn // json_tuple(json, null) from an analysis error into a typed STRING null. ``` `TypeCoercionSuite` and `AnsiTypeCoercionSuite` pass (108 tests). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
