Kimahriman commented on code in PR #53468: URL: https://github.com/apache/spark/pull/53468#discussion_r3837553646
########## sql/core/src/test/resources/sql-tests/inputs/array.sql: ########## @@ -206,3 +206,17 @@ select trim_array(array(1, 2, 3), 4); -- trim_array with NULL array or NULL n returns NULL select trim_array(CAST(null AS ARRAY<INT>), 1); select trim_array(array(1, 2, 3), CAST(null AS INT)); + +-- SPARK-54698: Confirm 0.0, -0.0, and NaN are handled appropriately for complex types. +select array_union( Review Comment: Addressed in commit c4fd1b945cd. I added Scala-side CollectionExpressionsSuite coverage for nested structs containing -0.0 and non-canonical NaN payloads across array_distinct, array_union, array_intersect, and array_except. I also added CollationExpressionSuite coverage for collated strings nested in structs and arrays, plus UTF8_BINARY_RTRIM cases such as 'a' versus 'a ' across the affected functions. The focused catalyst suites pass (74/74), and SQLQueryTestSuite passes both collations-basic.sql and collations-basic.sql_analyzer_test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
