HwangDongJun commented on PR #58216: URL: https://github.com/apache/spark/pull/58216#issuecomment-5385242002
Thanks so much for the detailed review, @dongjoon-hyun -- and you're right on every point. I re-scoped the PR per your suggestion: removed the `numDroppedExecutorManagementEvents` gauge and the two new tests entirely, and instead filled in the missing `queue.executorManagement.numDroppedEvents.count`, `queue.executorManagement.size`, and `queue.shared.*` entries in `docs/monitoring.md`'s `namespace=LiveListenerBus` list. Title and description are updated to match. Confirmed the diff against master is now docs-only (5 lines added, no source changes). Thanks again for catching that the signal was already exported -- much better outcome than adding a duplicate metric. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
