hulincup commented on PR #58158:
URL: https://github.com/apache/spark/pull/58158#issuecomment-5390472504
Hi maintainers, cc @uros-b,
Quick note on the failing "Build" check (titled "Workflow run detection
failed", conclusion=action_required): this is not a build or code failure.
Spark's fork-CI flow (notify_test_workflow.yml, pull_request_target) polls the
contributor's fork for a build_main.yml run matching the PR head SHA; my fork
(hulincup/spark) has never had GitHub Actions activated, so there are zero
workflow_runs to find. The notify script retried 3x, found no matching run, and
posted the action_required check. The only other check ("Notify test workflow")
passed.
For context, this is a docs-only change (+19/-0, single file
docs/_plugins/build-error-docs.py) already approved by @uros-b. The fix stops
the error-conditions doc generator from inserting backticks inside existing
inline-code spans, which previously leaked `<numResults>`/`<index>`
placeholders as raw HTML and broke the `<table>` on the sql-error-conditions
docs page. Local verification (per the commit message): regenerated
docs/_generated/error-conditions.html, raw `<numResults>` and `<index>` tag
leaks dropped 2→0 each, the table keeps a single matched `<table>`/`</table>`,
and previously-working messages are unchanged. This closes #58094.
So the failing Build check doesn't reflect the patch's correctness. I'm
enabling Actions on the fork and retriggering CI in parallel so the check
should turn green; but since this is a verified docs-only fix, a maintainer may
also merge it without waiting for fork-CI if comfortable.
Thanks for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
