Github user jeanlyn commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6833#discussion_r32492419
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
 ---
    @@ -197,7 +197,6 @@ case class InsertIntoHiveTable(
           table.hiveQlTable.getPartCols().foreach { entry =>
             orderedPartitionSpec.put(entry.getName, 
partitionSpec.get(entry.getName).getOrElse(""))
           }
    -      val partVals = 
MetaStoreUtils.getPvals(table.hiveQlTable.getPartCols, partitionSpec)
     
    --- End diff --
    
    I think 
https://github.com/apache/spark/pull/5876/files#diff-d579db9a8f27e0bbef37720ab14ec3f6L203
 should remove this code. @marmbrus. Right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to