HyukjinKwon opened a new pull request, #52:
URL: https://github.com/apache/spark-connect-rust/pull/52
### What changes were proposed in this pull request?
Replace the third-party GitHub Actions used across the CI workflows with
GitHub-authored
`actions/*` actions plus shell steps:
- `actions-rust-lang/setup-rust-toolchain`, `dtolnay/rust-toolchain` →
`rustup` (preinstalled
on the runners) + `actions/cache@v4` for the cargo/`target` cache the
action used to provide.
- `arduino/setup-protoc` → `protobuf-compiler` via `apt`/`brew`/`choco`
(per-OS).
- `PyO3/maturin-action` → `pip install maturin && maturin build`.
- `pypa/gh-action-pypi-publish` → `twine upload`.
It also fixes a pre-existing bug in `build_python_connect.yml`'s
`rust-checks` job, which ran
`cargo test -p spark-connect -p spark-connect-core` using the old crate
names — they were
renamed to `apache-spark-connect` / `apache-spark-connect-core`, so that job
could never pass.
### Why are the changes needed?
Every workflow currently fails with `startup_failure` ("This run likely
failed because of a
workflow file issue") on pushes to `master` and on pull requests, so the
repository has no
working CI. The workflow YAML is valid; the failure is that the ASF GitHub
org restricts
Actions to `actions/*` plus a vetted allowlist, and these workflows
referenced third-party
actions that aren't on it, so the runs never start. Using only `actions/*` +
shell removes
that dependency and lets CI run.
(I don't have org-admin access to read the exact allowlist to confirm this
is the sole cause,
but it is the standard cause for a new ASF repo where all workflows
`startup_failure` while the
YAML is valid, and using only allowlisted actions is required for ASF repos
regardless. If
Infra would rather allowlist the specific actions, that is an alternative to
this PR.)
### Does this PR introduce any user-facing change?
No — CI/infra only.
### How was this patch tested?
`actions/*`-only was verified (`grep` for non-`actions/*` `uses:` is empty)
and all four
workflow files parse as valid YAML. Full validation is the CI run on this PR
itself.
JIRA: https://issues.apache.org/jira/browse/SPARK-58983
This pull request and its description were written by Isaac.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
