dtenedor commented on code in PR #57686:
URL: https://github.com/apache/spark/pull/57686#discussion_r3857485444
##########
python/pyspark/sql/connect/local_server_pool.py:
##########
@@ -101,19 +113,84 @@ def resolved(command: str) -> str:
return hashlib.sha256(json.dumps(identity).encode("utf-8")).hexdigest()
-# The end of year 9999 UTC, as a Unix timestamp. ``created`` is a wall-clock
``time.time()``
-# reading, so no real clock reaches this for millennia; rejecting values
beyond it keeps a
-# corrupt far-future timestamp from looking perpetually fresh to age-based
reaping in the
-# layers above, which measure a member's age as ``time.time() - created``.
-_MAX_CREATED = 253402300799
+class _PoolStateRecord:
Review Comment:
Please remove the leading underscore from the class name, and add a class
comment describing what the class represents as an object and who uses it? Same
for RetiredState and other classes in this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
