shoemoney commented on PR #58292: URL: https://github.com/apache/spark/pull/58292#issuecomment-5417518121
Thank you @dongjoon-hyun for the review. Acknowledged the AGENTS.md and contributing guide and verified compliance: * Branch based on upstream/master (fix/oracle-number-scale), focused 2-file diff with no formatting or unrelated changes. * No non-ASCII characters introduced, source lines kept within 100 chars, and new config follows existing SQLConf grouping and naming conventions. * New config spark.sql.oracle.numberDefaultScale is documented, versioned 4.1.0, bounded 0 to 38, default 10 so behavior is backward compatible. * Hardcoded fallbacks in OracleDialect replaced with the configurable value and a warning log so users know the mapping is heuristic and how to tune it. Happy to file a JIRA if you would like one linked, or adjust the doc/version string. Please let me know if anything else from AGENTS.md or the contribution guide needs addressing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
