Yicong-Huang opened a new pull request, #58297:
URL: https://github.com/apache/spark/pull/58297

   ### What changes were proposed in this pull request?
   
   This PR removes redundant boilerplate in `python/pyspark/serializers.py` 
that is either a Python 2 leftover or made unnecessary by Python 3 semantics. 
None of it changes behavior:
   
   - Drop `FramedSerializer.dumps`, a verbatim duplicate (signature and 
docstring) of the inherited abstract `Serializer.dumps`.
   - Drop `Serializer.__ne__`: Python 3 derives `!=` from `__eq__` 
automatically. `__hash__` is intentionally kept, since it is not auto-derived 
once `__eq__` is defined.
   - Drop the no-op `FramedSerializer.__init__(self)` call in 
`CompressedSerializer.__init__`: neither `Serializer` nor `FramedSerializer` 
defines `__init__`, so it only resolves to `object.__init__`.
   - Collapse the duplicate `itertools` import: remove `from itertools import 
chain, product` and qualify the four usages as `itertools.chain` / 
`itertools.product`, consistent with the existing `itertools.islice` usage in 
the same file.
   
   ### Why are the changes needed?
   
   These are dead or redundant lines that add noise without adding behavior. 
Removing them makes the module easier to read and maintain.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Existing `python/pyspark/tests/test_serializers.py` passes. The change is 
behavior-preserving: the removed `dumps` override and `__init__` call were 
no-ops, and `!=` continues to work via Python 3's automatic derivation from 
`__eq__`.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to