HyukjinKwon opened a new pull request, #62:
URL: https://github.com/apache/spark-connect-rust/pull/62

   ### What changes were proposed in this pull request?
   
   Write the Rust llvm-cov report to `coverage-rust-llvm.json` (was
   `coverage-rust.json`), and read that name in the badge parser.
   
   ### Why are the changes needed?
   
   The coverage job's "Create/update badges branch" step fails on master:
   
   ```
   error: The following untracked working tree files would be overwritten by 
checkout:
        coverage-rust.json
   Please move or remove them before you switch branches.
   Aborting
   ```
   
   `coverage-rust.json` is the badge file tracked at the root of the `badges`
   branch (the shields.io endpoint the README reads). The Rust coverage report 
was
   written to that same path in the working tree, so `git checkout badges` 
refused
   to overwrite the untracked report with the branch's tracked badge, and the
   publish aborted.
   
   Renaming the raw report removes the name clash. The badge committed to the
   `badges` branch is still `coverage-rust.json`, so the README endpoint URL is
   unchanged.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No (CI badge publishing only).
   
   ### How was this patch tested?
   
   The remaining `coverage-rust.json` references are only the badge copied onto 
the
   `badges` branch; the report and parser now use `coverage-rust-llvm.json`, so 
no
   untracked file collides with the badges branch at checkout. (The publish step
   runs only on a master push, so it is verified on merge.)
   
   This pull request and its description were written by Isaac.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to