zhengruifeng opened a new pull request, #58326: URL: https://github.com/apache/spark/pull/58326
### What changes were proposed in this pull request? This is a follow-up to #58085. This PR appends `RpcDeadlines.release_relation` after all existing dataclass fields instead of inserting it between `release_session` and `artifact_status`. It also clarifies that ordinary non-reattachable query `ExecutePlan` calls have no deadline, while relation cleanup is the bounded exception. The deadline tests now cover the new default and disabled values and verify that the existing positional constructor arguments retain their original bindings. ### Why are the changes needed? The generated dataclass constructor accepts positional arguments. Inserting `release_relation` before existing fields silently shifted the bindings for `artifact_status`, `clone_session`, `get_status`, and `fetch_error_details`. Appending the field preserves those bindings. The documentation also made a categorical statement that non-reattachable `ExecutePlan` calls have no deadline immediately before documenting the relation-cleanup exception. Qualifying the statement removes that contradiction. ### Does this PR introduce _any_ user-facing change? Yes, within the unreleased `master` branch only. Existing positional `RpcDeadlines` constructor arguments keep their original meanings. The release RPC deadline behavior introduced by #58085 is unchanged. No released Spark version is affected. ### How was this patch tested? Built Spark with Hive support and ran: `conda run -n spark-dev-313 python/run-tests --testnames pyspark.sql.tests.connect.client.test_client_retries` The test suite passed. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: OpenAI Codex (GPT-5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
