cloud-fan commented on code in PR #57585:
URL: https://github.com/apache/spark/pull/57585#discussion_r3869689742
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/RelationResolution.scala:
##########
@@ -277,19 +277,21 @@ class RelationResolution(
None
}
- // For a `RelationCatalog` with no time-travel / write privileges,
the single-RPC
- // `loadRelation` answers both "is there a table?" and "is there a
view?" in one
- // call. Time-travel and write privileges apply to tables only, so
for those the
- // lookup falls through to the table-only `loadTable` path below;
views are not
- // reachable via the v2 fallback in those cases.
+ // For a `RelationCatalog` with no table-state options, time
travel, or write
+ // privileges, the single-RPC `loadRelation` answers both "is
there a table?" and "is
+ // there a view?" in one call. Table-state options, time travel,
and write privileges
Review Comment:
**Nit:**
These are conditions of this lookup, not properties of the
`RelationCatalog`; making the lookup the subject avoids implying that the
catalog cannot support them.
```suggestion
// When this lookup through a `RelationCatalog` has no
table-state options, time travel,
// or write privileges, the single-RPC `loadRelation` answers
both "is there a table?"
// and "is there a view?" in one call. Table-state options, time
travel, and write
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
