psavalle opened a new pull request, #58347:
URL: https://github.com/apache/spark/pull/58347
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'common/utils/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
This tackles part of
[SPARK-50569](https://issues.apache.org/jira/browse/SPARK-50569) by adding a
new configuration option:
```
spark.connect.session.manager.cleanupCachedData.enabled
```
We now track for each cached plan the sessions that have cached it. This
allows the following:
- When `spark.connect.session.manager.cleanupCachedData.enabled` is true and
the last session referencing a cached plan is closed, the data is unpersisted.
- `catalog.clearCache` now has an argument `allSessions`. By default,
`allSessions=true` and it clears dataframes persisted by all sessions. When
setting `allSessions=false`, only the dataframes persisted by the current
session are unpersisted.
### Why are the changes needed?
With Spark Connect, when a session calls `persist()` on a dataframe, it
remains cached even after the session is closed. However, it can be useful to
unpersist dataframes cached by a given session when it closes. Otherwise,
persisted data can accumulate.
Today, `sparkSession.catalog.clearCache` can also clear all dataframes that
have been persisted in the Spark Connect server, so it is also not possible for
a session to use it to unpersist all the dataframes it persisted, since it
would also unpersist all the dataframes persisted by other sessions.
### Does this PR introduce _any_ user-facing change?
- A new configuration option. The default behavior is preserved by default.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions
for the consistent environment, and the instructions could accord to:
https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
`Generated-by: codex-cli 0.147.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
