nchammas commented on code in PR #57010: URL: https://github.com/apache/spark/pull/57010#discussion_r3873874691
########## docs/_plugins/build_api_docs.rb: ########## @@ -277,10 +281,12 @@ def build_spark_scala_and_java_docs_if_necessary def build_scala_and_java_docs build_spark_if_necessary - print_header "Building Scala and Java API docs." + print_header "Building Scala and Java API docs" cd(SPARK_PROJECT_ROOT) - build_spark_scala_and_java_docs_if_necessary + if not (ENV['SKIP_UNIDOC'] == '1') Review Comment: The overloaded name here bothered me, so I updated the new skip flag for the doc build to `SKIP_UNIDOC_BUILD`. That way we don't have the inconsistent interpretation of value (truthy vs. `1`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
