fwc commented on PR #58350: URL: https://github.com/apache/spark/pull/58350#issuecomment-5442854876
Hi, thanks for pointing out the guideline! The change is test-only (plus the `private[connect] explainString`) and append-only (except removing obsolete `sql` declarations and reshuffling the `SharedSparkSession` and `checkError` code). Delta Lake currently has to awkwardl vendor this code to use it ([link](https://github.com/delta-io/delta/blob/master/spark/src/test/scala/org/apache/spark/sql/SessionQueryTest.scala)) and it is useful for simplerclassic-/connect agnostic tests there. This change should only (positively) impact downstream devs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
