Yicong-Huang commented on code in PR #58288:
URL: https://github.com/apache/spark/pull/58288#discussion_r3875782259


##########
dev/merge_spark_pr.py:
##########
@@ -1231,14 +1387,19 @@ def resolve_jira_issue(
 
         reconcile_jira_components(issue, title_components)
 
-    versions = asf_jira.project_versions("SPARK")
+    all_versions = asf_jira.project_versions("SPARK")
     # Consider only x.y.z, unreleased, unarchived versions
     versions = [
         x
-        for x in versions
+        for x in all_versions
         if not x.raw["released"] and not x.raw["archived"] and 
re.match(r"\d+\.\d+\.\d+", x.name)
     ]
     versions = sorted(versions, key=lambda x: x.name, reverse=True)
+    # Affects Version/s may legitimately name an already-released version, so 
validate the
+    # affects prompt against all unarchived x.y.z versions, not just the 
unreleased fix ones.
+    affects_available = {
+        x.name for x in all_versions if not x.raw["archived"] and 
re.match(r"\d+\.\d+\.\d+", x.name)

Review Comment:
   yup moved to a util func, thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to