dongjoon-hyun opened a new pull request, #58368:
URL: https://github.com/apache/spark/pull/58368
### What changes were proposed in this pull request?
This PR replaces the Bootstrap 2 class `btn-mini` with the Bootstrap 5
equivalent
in the History Server application list's `Event Log` column:
```js
// before
`<a href="${log}" class="btn btn-info btn-mini">Download</a>`
// after
`<a href="${log}" class="btn btn-sm btn-outline-secondary">Download</a>`
```
### Why are the changes needed?
`btn-mini` is a Bootstrap 2 class and does not exist in the bundled
Bootstrap 5.3.8:
```
$ grep -c "btn-mini"
core/src/main/resources/org/apache/spark/ui/static/bootstrap.min.css
0
```
As a result, the class is silently ignored and the `Download` control
renders as a
full-size solid blue button instead of the intended compact one, making the
row
taller than necessary and visually dominating the application list.
`btn btn-sm btn-outline-secondary` is already the convention used elsewhere
in the
Spark Web UI, for example in `executorspage.js` and `PagedTable.scala`.
### Does this PR introduce _any_ user-facing change?
Yes. On the History Server page, the `Event Log` column's `Download` button
is now
rendered as a compact outline button instead of a full-size solid blue
button.
The link target and behavior are unchanged.
### How was this patch tested?
Pass the CIs with `dev/lint-js`.
Manually verified the rendering of the `Event Log` column in both light and
dark
themes (`data-bs-theme` on the `html` element).
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
