ulysses-you commented on PR #58339: URL: https://github.com/apache/spark/pull/58339#issuecomment-5447750843
Thanks for the careful review, @peter-toth -- and for measuring the two extra wrong-results shapes. I've pushed 355d38891f4 addressing the findings; inline replies are on the individual threads. On the two body findings that had no thread: - **3 (description overstated the fix):** rewrote the description. It now says explicitly that a boolean marker cannot express *which* keys are trustworthy, so the sites that change the declared key set drop the keyed claim entirely: a key-dropping projection, a union whose merged keys are a superset of a flagged leg's keys, and `GroupPartitionsExec` with reducers. Findings 1, 2 and 4 are all closed in this PR (each with a repro or a guard), so no shapes are knowingly left broken. - **6 (affects-version and backport):** you're right -- `spark.sql.sources.v2.bucketing.shuffle.enabled` ships since 4.0.0 and a silent wrong-results fix is worth backporting. I've added a note to the description and will update SPARK-59050's affected versions and open backport PRs to the 4.x lines once this merges. One honest gap: finding 4 (reducers + flagged) is implemented as a conservative guard but without an end-to-end repro test, since the experiment needs `allowCompatibleTransforms` plus the reducer to be picked for the flagged side -- flagged in my inline reply if you'd like it added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
