ahshahid commented on PR #58003: URL: https://github.com/apache/spark/pull/58003#issuecomment-5448808731
ResultQuerystageExec extends the abstract class where you asked to move the fields... A democracy of barbarians is worse than A dictatorship On Thu, Aug 27, 2026, 10:11 PM Xiduo You ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In > sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala > <https://github.com/apache/spark/pull/58003#discussion_r3878072935>: > > > @@ -942,7 +943,8 @@ case class AdaptiveSparkPlanExec( > optimizeQueryStage(plan, isFinalStage = true), > postStageCreationRules(supportsColumnar), > "AQE Post Stage Creation") > - val resultStage = ResultQueryStageExec(currentStageId, optimizedRootPlan, resultHandler) > + val resultStage = ResultQueryStageExec(currentStageId, optimizedRootPlan, plan.canonicalized, > > For ResultQueryStageExec, we should not make canonicalized change , the > semantics of ResultQueryStageExec is plan + resultHandler. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/spark/pull/58003?email_source=notifications&email_token=AC6XG2H7TOX3VEPBHYHX4DL5MEIBHA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMBUHAYDSNJWG42KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#pullrequestreview-5048095674>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AC6XG2GEPJVQAIPKUJ227PT5MEIBHAVCNFSNUABEKJSXA33TNF2G64TZHMYTOMJWGU3DKOB3JFZXG5LFHM2TCNBYGEZDSOBZHCQXMAQ> > . > Triage notifications, keep track of coding agent tasks and review pull > requests on the go with GitHub Mobile for iOS > <https://github.com/notifications/mobile/ios/AC6XG2FWLBNIATCLO3MYO535MEIBHA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMBUHAYDSNJWG42KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y> > and Android > <https://github.com/notifications/mobile/android/AC6XG2C54REIJ4LUD755I5T5MEIBHA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMBUHAYDSNJWG42KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. > Download it today! > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
